fix: precision for invoice outstandings #38323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GursheenK
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
deepeshgarg007
merged commit 190f77a
into
frappe:version-13-hotfix
6 of 7 checks passed
|
🎉 This PR is included in version 13.54.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When a payment is made against an Invoice with the allocated amount having precision more than that of the outstanding amount precision, the outstanding amount in the invoice is set to have higher precision than the currency precision. Therefore, when another payment is reconciled against this invoice, the validation for ensuring that the outstanding is correct fails.
Screenshot
Fix
Set the balance amount in
update_outstanding_amtby using the precision for the field.